fix: Build QNS docker image with debug symbols #2181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So panic stack traces are useful.
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2181 +/- ##
=======================================
Coverage 95.39% 95.39%
=======================================
Files 112 112
Lines 36373 36373
=======================================
Hits 34697 34697
Misses 1676 1676 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Benchmark resultsPerformance differences relative to 9b5ec71. coalesce_acked_from_zero 1+1 entries: 💔 Performance has regressed. time: [106.87 ns 107.22 ns 107.56 ns]
change: [+7.0815% +7.5526% +7.9987%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 3+1 entries: 💔 Performance has regressed. time: [124.80 ns 125.13 ns 125.49 ns]
change: [+5.3384% +5.9001% +6.4507%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 10+1 entries: 💔 Performance has regressed. time: [124.55 ns 125.09 ns 125.73 ns]
change: [+6.0594% +6.6621% +7.2777%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 1000+1 entries: 💔 Performance has regressed. time: [104.82 ns 110.52 ns 122.96 ns]
change: [+5.2796% +7.9968% +13.360%] (p = 0.00 < 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [110.99 ms 111.05 ms 111.11 ms]
change: [-0.8330% -0.7602% -0.6816%] (p = 0.00 < 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [26.213 ms 27.218 ms 28.224 ms]
change: [-5.5220% -0.4164% +4.6803%] (p = 0.88 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [34.048 ms 35.744 ms 37.423 ms]
change: [-10.127% -3.9492% +2.4910%] (p = 0.23 > 0.05)
transfer/pacing-false/same-seed: No change in performance detected. time: [25.833 ms 26.484 ms 27.140 ms]
change: [-0.8418% +2.8485% +7.1174%] (p = 0.16 > 0.05)
transfer/pacing-true/same-seed: No change in performance detected. time: [42.567 ms 44.731 ms 46.917 ms]
change: [-1.2209% +5.9377% +12.697%] (p = 0.08 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected. time: [113.17 ms 113.71 ms 114.20 ms]
thrpt: [875.64 MiB/s 879.46 MiB/s 883.59 MiB/s]
change:
time: [-17.236% -6.5131% +0.2251%] (p = 0.30 > 0.05)
thrpt: [-0.2246% +6.9669% +20.825%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected. time: [312.35 ms 315.93 ms 319.52 ms]
thrpt: [31.297 Kelem/s 31.653 Kelem/s 32.015 Kelem/s]
change:
time: [-0.4338% +1.1524% +2.8155%] (p = 0.16 > 0.05)
thrpt: [-2.7384% -1.1392% +0.4357%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected. time: [33.907 ms 34.057 ms 34.218 ms]
thrpt: [29.225 elem/s 29.362 elem/s 29.492 elem/s]
change:
time: [-0.8647% +0.0083% +0.8214%] (p = 0.99 > 0.05)
thrpt: [-0.8147% -0.0083% +0.8722%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
mxinden
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So panic stack traces are useful.